Move systemPropertiesOverrideTest to separate source set
#137492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today `:server:systemPropertiesOverrideTest` uses the same source set as `:server:test`, but runs a disjoint set of tests via includes & excludes. This forces every developer to choose in their IDE between the two tasks when running any unit test in `:server` even though there's only one appropriate task to run for any particular test. This commit moves the serverless-specific unit tests into their own source set to remove this friction in the development flow.
DaveCTurner
added
>test
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
elasticsearchmachine
added
the
Team:Distributed Coordination
ywangd
approved these changes
Nov 5, 2025
|
|
||
| tasks.named("test").configure { | ||
| systemProperty 'es.stateless.allow.index.refresh_interval.override', 'true' | ||
| // systemProperty 'es.serverless_transport', 'true' |
There was a problem hiding this comment.
We still need this, right? I wonder why the CI didn't fail?
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Nov 5, 2025
These tests relate to system properties set only in serverless Elasticsearch so there's no need for them in the `8.19` branch. Moreover, as with elastic#137492, this extra Gradle task forces every developer to make an extra choice when running tests in `:server`. This commit removes the unnecessary tests and the corresponding Gradle task.
DaveCTurner
added a commit
that referenced
this pull request
Nov 5, 2025
These tests relate to system properties set only in serverless Elasticsearch so there's no need for them in the `8.19` branch. Moreover, as with #137492, this extra Gradle task forces every developer to make an extra choice when running tests in `:server`. This commit removes the unnecessary tests, the corresponding Gradle task, and the now-untested code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today
:server:systemPropertiesOverrideTestuses the same source set as:server:test, but runs a disjoint set of tests via includes &excludes. This forces every developer to choose in their IDE between the
two tasks when running any unit test in
:servereven though there'sonly one appropriate task to run for any particular test.
This commit moves the serverless-specific unit tests into their own
source set to remove this friction in the development flow.